Skip to content

MAINT: Avoid use of deprecated _PyDict_GetItemStringWithError in f2py #29083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025

Conversation

ngoldbaum
Copy link
Member

c.f. #26282 (comment)

Ping @seberg to double check that the logic is identical between the two branches.

@ngoldbaum ngoldbaum added component: numpy.f2py 39 - free-threading PRs and issues related to support for free-threading CPython (a.k.a. no-GIL, PEP 703) labels May 29, 2025
@ngoldbaum ngoldbaum added the 09 - Backport-Candidate PRs tagged should be backported label May 29, 2025
@seberg seberg changed the title MNT: Avoid use of deprecated _PyDict_GetItemStringWithError in f2py MAINT: Avoid use of deprecated _PyDict_GetItemStringWithError in f2py May 29, 2025
Copy link
Member

@seberg seberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, looks fine, thanks.

@charris charris merged commit 725d53f into numpy:main May 29, 2025
75 checks passed
@charris
Copy link
Member

charris commented May 29, 2025

Thanks Nathan.

@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label May 29, 2025
@rgommers rgommers added the 09 - Backport-Candidate PRs tagged should be backported label May 30, 2025
@rgommers rgommers added this to the 2.4.0 release milestone May 30, 2025
@rgommers
Copy link
Member

Thanks!

@charris I marked this as backport candidate to the 2.3.x branch because it's needed for Python 3.14 support.

@charris
Copy link
Member

charris commented May 30, 2025

@rgommers Already backported.

@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label May 30, 2025
@rgommers
Copy link
Member

Sorry, missed that - you're way too fast for me:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
03 - Maintenance 39 - free-threading PRs and issues related to support for free-threading CPython (a.k.a. no-GIL, PEP 703) component: numpy.f2py
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants