BUG: make round consistently return a copy #29137
Merged
+20
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs a release note. |
|
Release note snippet added. |
seberg
reviewed
Aug 14, 2025
| @@ -637,8 +637,7 @@ PyArray_Round(PyArrayObject *a, int decimals, PyArrayObject *out) | |||
| return (PyObject *)out; | |||
| } | |||
| else { | |||
| Py_INCREF(a); | |||
| return (PyObject *)a; | |||
| return PyArray_Copy(a); | |||
There was a problem hiding this comment.
Suggested change
| return PyArray_Copy(a); | |
| return PyArray_NewCopy(a, NPY_KEEPORDER); |
There was a problem hiding this comment.
Oh... This made the test fail, but I hope that needs a test adjustment only :).
There was a problem hiding this comment.
Well, I parroted a PyArray_Copy from the complex dtype code path of this same function, so if we insist on NPY_KEEPORDER for real dtypes, we need to follow for complex dtypes, too. Done now.
Otherwise, `round` returns a view for integer arguments and a copy otherwise. All other "rounding" functions (ceil, floor, trunc, rint), always return copies. Thus, make `round` consistent with them.
bwhitt7
pushed a commit
to bwhitt7/numpy
that referenced
this pull request
Aug 24, 2025
* BUG: make round consistently return a copy Otherwise, `round` returns a view for integer arguments and a copy otherwise. All other "rounding" functions (ceil, floor, trunc, rint), always return copies. Thus, make `round` consistent with them. * DOC: add a release note snippet for the `round` change * TST: add a test for round preserving the order * MAINT: address review comments * BUG: round: NPY_KEEPORDER for complex arrays, too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise,
roundreturns a view for integer arguments and a copy otherwise. All other "rounding" functions (ceil, floor, trunc, rint), always return copies. Thus, makeroundconsistent with the rest of them.fixes #29124