Remove scons support #2914
Merged
Remove scons support #2914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes files and code supporting scons builds. After this change numpy will only support builds using distutils or bento. The removal of scons has been discussed on the list several times and a decision has been made that scons support is no longer needed. This was originally discussed for numpy 1.7 and because the distutils and bento methods are still available we are skipping the usual deprecation period.
|
Only scons scripts inside numpy should be removed, so the removal inside cpucaps and co is wrong. |
These tools are not directly related to numpy builds.
|
@cournape Should be fixed. |
|
@cournape David, before I push more up here, could you comment on the removal of the top level |
|
Those can definitely be removed On Mon, Jan 14, 2013 at 3:04 PM, Charles Harris notifications@github.comwrote:
|
These references were in MANIFEST.in, doc/summarize.py, release.sh, and numpy/testing/noseclasses.py and involved scons files that have been removed, mostly setupscons.py and setupsconsegg.py that were in the top level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The files and code needed to support SCons builds is removed.
@cournape David, can you check the code removal in the distutils functions? It may be possible the remove numpy/distutils/numpy_distribution.py as well, but that wasn't clear to me. Also, can numpy/core/setup_common.py now be merged with the setup.py file?