Fix incorrect grammar in TypeError message for ufunc argument count mismatch #29308
+19
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a grammatical issue in the
TypeError
message raised when a ufunc (such asnp.hypot
) receives an incorrect number of positional arguments.Previously, the message always used:
This PR ensures that when exactly one argument is passed, the message reads:
Changes
npy_argparse.c
ufunc_object.c
test_umath.py
to assert correct grammar for singular and plural argument count cases.Related Issue
Closes #29259
Additional Notes
pytest numpy/_core/tests/test_umath.py -k TestHypotErrorMessages