MAINT: remove internal uses of assert_warns and suppress_warnings #29322
+318
−362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngoldbaum
commented
Jul 5, 2025
seberg
approved these changes
Jul 6, 2025
There was a problem hiding this comment.
Looks good to me, didn't find any larger change that I would worry about. I suspect many would be better as np.errstate, but sometimes that may also be less precise (i.e. doesn't include the function that caused the warning).
The one thing I think, I care about a bit is that it would be nice to use @pytest.mark.filterwarnings() instead of those massive indentations. (Using pytest.warns() as rec would also make the diff smaller in a few places and be nicer).
But, overall nice. And pytest.warns and some other changes improve things quite a bit!
|
There are some unrelated failures because of cache mismatches reported by apt. Let's bring this in - thanks for looking this over and the suggestions @seberg! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards fixing #29293, also see scipy/scipy#23275 where I did this in SciPy.
The only nontrivial changes (IMO, anyway) are in
numpy/ma/tests/test_core.py.