Skip to content

BLD: update highway submodule to latest master #29329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2025
Merged

Conversation

clin1234
Copy link
Contributor

@clin1234 clin1234 commented Jul 7, 2025

Fixes #29130

@github-actions github-actions bot added the 36 - Build Build related PR label Jul 7, 2025
@seberg
Copy link
Member

seberg commented Jul 7, 2025

Hmmm, the test failures seems quite likely real:

No, nevermind... This is again a bad test, the test must not use ArrayPriorityMinus0(2), but instead create a view.

__________________ TestUfunc.test_array_wrap_array_priority ___________________

self = <test_ufunc.TestUfunc object at 0x0000037C444DA740>

    def test_array_wrap_array_priority(self):
        class ArrayPriorityBase(np.ndarray):
            @classmethod
            def __array_wrap__(cls, array, context=None, return_scalar=False):
                return cls
    
        class ArrayPriorityMinus0(ArrayPriorityBase):
            __array_priority__ = 0
    
        class ArrayPriorityMinus1000(ArrayPriorityBase):
            __array_priority__ = -1000
    
        class ArrayPriorityMinus1000b(ArrayPriorityBase):
            __array_priority__ = -1000
    
        class ArrayPriorityMinus2000(ArrayPriorityBase):
            __array_priority__ = -2000
    
        x = np.ones(2).view(ArrayPriorityMinus1000)
        xb = np.ones(2).view(ArrayPriorityMinus1000b)
        y = np.ones(2).view(ArrayPriorityMinus2000)
    
        assert np.add(x, y) is ArrayPriorityMinus1000
        assert np.add(y, x) is ArrayPriorityMinus1000
        assert np.add(x, xb) is ArrayPriorityMinus1000
        assert np.add(xb, x) is ArrayPriorityMinus1000b
>       assert np.add(np.zeros(2), ArrayPriorityMinus0(2)) is ArrayPriorityMinus0
E       RuntimeWarning: invalid value encountered in add

@clin1234
Copy link
Contributor Author

clin1234 commented Jul 7, 2025

What does "Pending authors' response" imply here? As far as I can tell, CI passes

@seberg
Copy link
Member

seberg commented Jul 7, 2025

@clin1234 I had triggered a re-run, it had failed and it looked even possibly related on first sight.

Anyway, should be good, but I'll let @seiko2plus or so do the honors.

Copy link
Member

@r-devulap r-devulap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @clin1234

@r-devulap r-devulap merged commit fb83d4c into numpy:main Jul 7, 2025
82 of 83 checks passed
@github-project-automation github-project-automation bot moved this from Pending authors' response to Completed in NumPy first-time contributor PRs Jul 7, 2025
@clin1234 clin1234 deleted the gcc-16 branch July 7, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
36 - Build Build related PR
Projects
Development

Successfully merging this pull request may close these issues.

Cannot compile numpy with GCC 16.0.0 (development version)
3 participants