Skip to content

TYP: correct default value of unicode in chararray.__new__ and of full in polyfit #29340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2025

Conversation

MarcoGorelli
Copy link
Member

@MarcoGorelli MarcoGorelli commented Jul 8, 2025

These annotations show Literal[True] as the default, even though the default is actually False

@MarcoGorelli MarcoGorelli changed the title TYP: correct default value of unicode in chararray.__new__ TYP: correct default value of unicode in chararray.__new__ and of full in polyfit Jul 8, 2025
@MarcoGorelli MarcoGorelli marked this pull request as ready for review July 8, 2025 10:19
@jorenham
Copy link
Member

jorenham commented Jul 8, 2025

These annotations show Literal[True] as the default, even though the default is actually False

In Pylance?

@jorenham jorenham merged commit 46c0bff into numpy:main Jul 8, 2025
79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants