Skip to content

DOC: Fix NEP 49 Resolution Link Formatting (part of #29328) #29347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 9, 2025
Merged

DOC: Fix NEP 49 Resolution Link Formatting (part of #29328) #29347

merged 3 commits into from
Jul 9, 2025
+2 −3

Conversation

Toshaksha
Copy link
Contributor

@Toshaksha Toshaksha commented Jul 9, 2025 •
edited by rossbar
Loading

Closes #29328

This PR fixes the formatting of the :Resolution: field in nep-0049-data-allocation-strategies.rst
to use proper ReStructuredText link syntax, making the link render correctly in documentation.

No other changes to content.

@Toshaksha Toshaksha changed the title Fix NEP 49 Resolution Link Formatting DOC: Fix NEP 49 Resolution Link Formatting (part of #29328) Jul 9, 2025
@rossbar
Copy link
Contributor

rossbar commented Jul 9, 2025

@Toshaksha want to make the same change for NEP 38 as well? It'd be good to get #29328 resolved all at once.

@Toshaksha
Copy link
Contributor Author

@Toshaksha want to make the same change for NEP 38 as well? It'd be good to get #29328 resolved all at once.

Sure, I’ll take care of NEP 38 as well and open a follow-up PR shortly. Thanks for the heads-up!

@rossbar
Copy link
Contributor

rossbar commented Jul 9, 2025

Sure, I’ll take care of NEP 38 as well and open a follow-up PR shortly. Thanks for the heads-up!

It would be best if you incorporated the change into this PR. All that's required to do so is to checkout the branch used for this PR (NEP49-changes), make a new commit, and push that commit to this branch.

@Toshaksha
Copy link
Contributor Author

All done — NEP 49 and NEP 38 resolution links updated as requested. Let me know if anything else needs tweaking!

rossbar
rossbar reviewed Jul 9, 2025
View reviewed changes
rossbar
rossbar approved these changes Jul 9, 2025
View reviewed changes
Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Toshaksha !

@rossbar rossbar merged commit 4ff1cc1 into numpy:main Jul 9, 2025
76 checks passed
@Toshaksha
Copy link
Contributor Author

Thanks so much for the review and merge, @rossbar! Glad I could help clean this up. Looking forward to contributing more!

@Toshaksha Toshaksha deleted the NEP49-changes branch July 9, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossbar rossbar rossbar approved these changes

Assignees
No one assigned
Labels
04 - Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DOC: NEP 49, 38 "header" formatting
2 participants
@Toshaksha @rossbar