TST: don't explicitly specify -j in TSAN build #29512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[skip cirrus] [skip azp] [skip circleci]
|
Looks like it does shave a little time off the build. Compare this PR: https://github.com/numpy/numpy/actions/runs/16756013096/job/47438700865 And another recent PR: https://github.com/numpy/numpy/actions/runs/16757071300/job/47446778174 |
|
Let's give it a shot. Thanks Nathan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c.f. #29487 (comment). It seemed easier just to send in a PR for this than ask @m-clare to do it.
I don't remember if I explicitly set it to build with 2 cores because TSAN builds use a lot of RAM or if I did it for some other reason. Let's see if letting meson choose the correct value is problematic.