Skip to content

ENH, SIMD: Optimize the argmax/argmin implementation based on Highway… #29566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
+531 −394
Open

ENH, SIMD: Optimize the argmax/argmin implementation based on Highway… #29566

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
09486f9
ENH, SIMD: Optimize the argmax/argmin implementation based on Highway…
ixgbe Aug 15, 2025
405c24f
fix compile error C2131: expression did not evaluate to a constant
ixgbe Aug 15, 2025
a6af882
fix compile error LNK2001: unresolved external symbol _LONGDOUBLE_argmax
ixgbe Aug 15, 2025
c53bd0f
fix compile error when sizeof(long double)==sizeof(double)
ixgbe Aug 15, 2025
c683293
fix compile error when sizeof(long double)==sizeof(double)[2]
ixgbe Aug 15, 2025
544b3a2
fix compile error when sizeof(long double)==sizeof(double)[3]
ixgbe Aug 18, 2025
80752bf
fix compile error when sizeof(long double)==sizeof(double)[4]
ixgbe Aug 18, 2025
6ee215a
fix compile error when sizeof(long double)==sizeof(double)[5]
ixgbe Aug 18, 2025
c41b685
fix compile error when sizeof(long double)==sizeof(double)[6]
ixgbe Aug 18, 2025
4d0d623
fix compile error when sizeof(long double)==sizeof(double)[7]
ixgbe Aug 18, 2025
d1d2c64
fix compile error when sizeof(long double)==sizeof(double)[8]
ixgbe Aug 18, 2025
c88e8ac
fix compile error when sizeof(long double)==sizeof(double)[9]
ixgbe Aug 18, 2025
def2372
fix compile error when sizeof(long double)==sizeof(double)[10]
ixgbe Aug 18, 2025
818ef90
Merge branch 'numpy:main' into argmax_argmin_hwy
ixgbe Aug 19, 2025
7c04810
fix s390x test[1]
ixgbe Aug 19, 2025
7c6a683
fix s390x test[2]
ixgbe Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix compile error when sizeof(long double)==sizeof(double)[8]
  • Loading branch information
@ixgbe
ixgbe committed Aug 18, 2025
commit d1d2c648582ce6a22bb95be93c35d132bd441b51
12 changes: 9 additions & 3 deletions numpy/_core/src/multiarray/argfunc.dispatch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,10 @@ template <typename T>
struct OpGt {
using Degraded = std::conditional_t<std::is_same_v<T, long double>, OpGt<double>, OpGt<T>>;
#if NPY_HWY
template <typename D = T, typename = std::enable_if_t<kSupportLane<D>>, typename V = Vec<D>>
template <
typename D = T,
typename = std::enable_if_t<kSupportLane<D> && !std::is_same_v<D, long double>,
typename V = Vec<D> >
HWY_INLINE HWY_ATTR auto operator()(const V &a, const V &b) const {
return hn::Gt(a, b);
}
Expand All @@ -33,7 +36,10 @@ template <typename T>
struct OpLt {
using Degraded = std::conditional_t<std::is_same_v<T, long double>, OpLt<double>, OpLt<T>>;
#if NPY_HWY
template <typename D = T, typename = std::enable_if_t<kSupportLane<D>>, typename V = Vec<D>>
template <
typename D = T,
typename = std::enable_if_t<kSupportLane<D> && !std::is_same_v<D, long double>,
typename V = Vec<D> >
HWY_INLINE HWY_ATTR auto operator()(const V &a, const V &b) const {
return hn::Lt(a, b);
}
Expand Down Expand Up @@ -313,7 +319,7 @@ arg_max_min_func(T *ip, npy_intp n, npy_intp *mindx)
}

#if NPY_HWY
if constexpr (kSupportLane<T>) {
if constexpr (kSupportLane<T> && std::is_same_v<T, D>) {
if constexpr (sizeof(T) <= 2) {
*mindx = simd_argfunc_small<D, typename Op::Degraded>(ip, n);
return 0;
Expand Down
Loading