Skip to content

BLD: wire up ASIMDDP feature to ARM_FEATURES #29579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2025
Merged

Conversation

mgorny
Copy link
Contributor

@mgorny mgorny commented Aug 17, 2025

Add the ASIMDDP feature to the ARM_FEATURES dictionary, to fix an error when it is explicitly listed in cpu-baseline.

Fixes #29570

@github-actions github-actions bot added the 36 - Build Build related PR label Aug 17, 2025
Add the `ASIMDDP` feature to the `ARM_FEATURES` dictionary, to fix
an error when it is explicitly listed in `cpu-baseline`.

Fixes numpy#29570

Signed-off-by: Michał Górny <mgorny@gentoo.org>
@ngoldbaum
Copy link
Member

maybe one of @Mousius @seiko2plus or @r-devulap can take a look at this?

Copy link
Member

@r-devulap r-devulap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Perhaps @Mousius might want to take a look.

@Mousius Mousius merged commit f3201c8 into numpy:main Aug 20, 2025
77 checks passed
@Mousius
Copy link
Member

Mousius commented Aug 20, 2025

Makes sense that this should work 😸 Thanks @mgorny!

@mgorny mgorny deleted the asimddp branch August 21, 2025 04:12
@mgorny
Copy link
Contributor Author

mgorny commented Aug 21, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
36 - Build Build related PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: ASIMDDP CPU feature on ARM is not wired in
4 participants