Skip to content

Conversation

bwhitt7
Copy link
Contributor

@bwhitt7 bwhitt7 commented Aug 20, 2025

This PR is related to #29552 and a continuation of #29596, with the goal of making NumPy's testing suite more thread safe. This changes the setup methods for 4 more testing files in numpy/_core, as well as moving some variables that were only used once to be inside the test they're used in instead of declared in a method.

With this PR, you should be able to call the tests from these files with pytest-run-parallel and have all tests successfully run in parallel threads (and also run normally without pytest-run-parallel).

Copy link
Member

@ngoldbaum ngoldbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it's all only mechanical changes.

@ngoldbaum
Copy link
Member

Thanks @bwhitt7!

@ngoldbaum ngoldbaum merged commit 1aa0510 into numpy:main Aug 22, 2025
78 checks passed
bwhitt7 added a commit to bwhitt7/numpy that referenced this pull request Aug 24, 2025
@bwhitt7 bwhitt7 deleted the setup-rewrite2 branch August 25, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants