DOC: clarify numpy.asarray parameter 'order' #29606
Open
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed description to make explicit that setting 'A' requires user to set 'copy' to 'True' to get the described behavior. Made explicit that 'A' has two cases where it acts as equivalent to setting 'F'. See 28247.
See 28247. Changed description of 'order' to make the behavior of 'A' more explicit and how to cause it to preserve non-contiguous Fortran-order. Changed description of 'C' and 'F' to clarify that output will be contiguous.
See 28247. To differentiate between 'A' and 'K', made explicit that 'A' will not ensure the output is contiguous. 'K' has more complex behavior related to flags and stride detection, but will try to keep the output as close as possible to the input.
See 28247. Made explicit that 'C' and 'F' can copy input to output, 'A' does not ensure contiguous output.
seberg
reviewed
Aug 22, 2025
| 'C' gives a row-major layout (C-style), | ||
| 'F' gives a column-major layout (Fortran-style). | ||
| 'C' and 'F' will copy if needed to ensure the output format. | ||
| 'A' (any) is equivalent to 'F' if input a is non-contiguous or Fortran-contiguous, otherwise, it is equivalent to 'C'. Unlike 'C' or 'F', 'A' does not ensure that the result is contiguous. |
There was a problem hiding this comment.
Yeah, seems good, can you break the long line though?
Also, can you see which other places have the identical comment, we should change them all (where applicable, which might be some exceptions but not sure).
There was a problem hiding this comment.
Will do.
- formality question: Is it okay to change it on my repo directly (since it's just replacing ' ' with '\n') or should I do the whole process again with "change locally, spin build, spin test, spin lint, push to personal repo, create new pull request?" Or is there a procedure to alter a repo that had a push request already made?
- Did you want me to hit up anywhere that had 'order' with 'A' and 'K' args, or anywhere that had the whole
Fortran contiguous, ‘C’ otherwise ‘K’ (keep) preserve input order Defaultsstring (which has line-breaks but no punctuation)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #28247. Made explicit that 'C' and 'F' can copy input to ensure output format, 'A' does not ensure contiguous output. Kept 'K' the same because all the stride analysis/flag-handling behavior should be extraneous to the end user.