BUG: Added manual checks for self-nested sequences during array creation #29623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe that #29569 also addresses this, but I might be wrong |
jorenham
reviewed
Aug 25, 2025
| /* Check for self-nested sequences to prevent RAM exhaustion */ | ||
| if (is_sequence) { | ||
| if (PySequence_Check(objects[0])) { | ||
| if (objects[0] == obj) { |
There was a problem hiding this comment.
this still leaves
l = [[]]
l[0].append(l)
l[0].append(l)
np.array(l)and 62 other cases like these
There was a problem hiding this comment.
(not that that's necessarily a problem, it's just something to be aware of)
There was a problem hiding this comment.
Yeah, I got u, this addresses only one specific and most common case of self-nesting. Thanks !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when creating a NumPy array with self-nested sequences, it causes a quick RAM exhaustion, as also described in #29620, all due to the cyclic recursions.
With these changes, when creating an array with sequences, a check for self-nesting is performed first, which prevents any further cyclic recursions.
Before:
Now:
closes #29620