New iterator #36
Merged
New iterator #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd rather not edit the history too much if I can get away with it - I cleaned up the early commits when it was clear the iterator worked well. I could possibly separate out the ufunc conversion and the backwards compatibility changes, but they have to go at the end since they depend on the code for the iterator buffering subsystem. Also, as it is now, pretty much every commit will build and run, whereas if I edit the history there's no way I can spend the time to ensure that holds anymore. |
|
Well, it was worth a try ;) I still think it worth separating out the backward compatibility part if it isn't too much trouble. |
With this patch, the latest scipy trunk (7087), built against NumPy 1.5.1, passes all tests when run against the numpy trunk. The single failing test, test_imresize, fails because it tests all float types, and the new 'half' type lacks the precision to pass that test.
Now in methods.c each argument gets its own line, so its easier to validate.
This function implements the numpy.empty_like semantics, but supports the new NPY_KEEPORDER enumeration value as well as switching to a different data type.
fangerer
pushed a commit
to hpyproject/numpy-hpy
that referenced
this pull request
Jul 7, 2022
Merge in ~STEPAN.SINDELAR_ORACLE.COM/numpy-hpy from mq/findarrayprep to labs-hpy-port * commit '50a763b10a3f7541806cf6dc2ae262cfe80e7a54': Migrate function _find_array_prepare to HPy
luyahan
pushed a commit
to plctlab/numpy
that referenced
this pull request
Apr 25, 2024
feat: Add vext_s8
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the NumPy and SciPy tests pass now (with a small scipy patch) on my machine. I think there's no a way to get the buildbot to pull from my branch without changing its configuration, so maybe merging the branch now is a good idea.