FIX: bug in np.where and recarray swapping #395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks sensible to me. |
| @@ -169,6 +169,34 @@ def test_endian_bool_indexing(self,level=rlevel): | |||
| assert_(np.all(a[ya] > 0.5)) | |||
| assert_(np.all(b[yb] > 0.5)) | |||
|
|
|||
| def test_endian_where(self,level=rlevel): | |||
| """GitHuB issue #369""" | |||
| net = np.zeros(3, dtype='>f4') | |||
There was a problem hiding this comment.
Not sure if it matters or is the case. But it may be necessary to test both '>' and '<' for big-endian machines where I guess the singletons should be big endian? would be just a second net here and a second test below (unless there is a way to make net non-native).
There was a problem hiding this comment.
Would you mind sending a PR for this please? I am going to merge this issue now.
|
Got reviewed by @njsmith, merging. |
certik
added a commit
that referenced
this pull request
Aug 31, 2012
FIX: bug in np.where and recarray swapping
This was referenced Oct 16, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #369 and the Ticket 2185