FIX: use py24-compatible version of virtualenv on Travis #431
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -15,4 +17,4 @@ EOF | |||
| ./configure --prefix=$PWD/install | |||
| make | |||
| make install | |||
| virtualenv -p install/bin/python2.4 --distribute $VIRTENV | |||
| install/bin/python2.4 ./virtualenv.py --distribute $VIRTENV | |||
There was a problem hiding this comment.
I suspect you need to use ../.virtualenv.py here, because it is executed from the Python directory.
|
Thanks for the catch -- I forgot that when testing this on Patsy, I didn't so much confirm that it worked as confirm that Travis had gotten wedged and then give up until later. The amended commit does actually work: http://travis-ci.org/#!/pydata/patsy/jobs/2377994 |
Travis recently upgraded to virtualenv 1.8, which has dropped support for Python 2.4. So, in our Python 2.4 setup script, we need to explicitly fetch and use virtualenv 1.7. Likewise for pip 1.1. File imported from the already-fixed version for patsy: https://github.com/pydata/patsy/blob/0316d2901f4195db06e8091c15f37d9fe4ad09de/.travis-make-py24-virtualenv.sh
njsmith
added a commit
that referenced
this pull request
Sep 11, 2012
FIX: use py24-compatible version of virtualenv on Travis
This was referenced Sep 11, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Travis recently upgraded to virtualenv 1.8, which has dropped support
for Python 2.4. So, in our Python 2.4 setup script, we need to
explicitly fetch and use virtualenv 1.7.
File imported from the already-fixed version for patsy:
https://github.com/pydata/patsy/blob/ed4073adaf88463b67a1c1e2b0f02aa1eba2b944/.travis-make-py24-virtualenv.sh