BUG: handle non integer types for multinomial/dirichlet size #4348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
for review btw can we just add cython as dependency and remove the mtrand.c? |
| if seed is None: | ||
| errcode = rk_randomseed(self.internal_state) | ||
| else: | ||
| rk_seed(operator.index(seed), self.internal_state) |
There was a problem hiding this comment.
What does operator.index do here?
There was a problem hiding this comment.
get an integer, though I guess it could be skipped as the float cases is already handled below
|
LGTM. |
|
+1 for Cython as dependency when building from git repo. Not from a source release. |
charris
added a commit
that referenced
this pull request
Feb 22, 2014
BUG: handle non integer types for multinomial/dirichlet size
|
Thanks Julian. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-3173