Fix unicode repr object #459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You have test failures on Py3 (see travis logs). |
|
Should be okay now. |
| def test_unicode_object_array(): | ||
| import sys | ||
| if sys.version_info[0] >= 3: | ||
| expected = "array(['é'], dtype=object)" |
There was a problem hiding this comment.
Not sure whether we care, but if it's desireable to keep the source files as ascii, I think this line could be written
expected = u"array(['\xe9'], dtype=object)"
and work on both py2 and py3.
There was a problem hiding this comment.
Err, that's if we're running stuff through 2to3. If not then we can leave off the u at the beginning and I believe it should still work (though be slightly more confusing).
|
Any reason not to merge this? Lost track of the release schedule, but it'd be great to get this in if possible. |
|
I thought maybe others would comment on the bit about including raw unicode characters in source files, but apparently not, and the tests pass, so hey. |
|
Backported in #2842. |
BvB93
pushed a commit
to BvB93/numpy
that referenced
this pull request
Dec 19, 2020
It's been non-functional for the past 8 years (xref numpy#459)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you try to print an array with unicode in it and an object dtype, it currently fails. This happens often for me working with pandas because it defaults to the object dtype for non-numerical arrays. This is because the fallback for the formatting is str. Is there any reason not to use the numpystr function here that can handle unicode?
Reproduce