TST: win32 also does not provide 16 byte alignment #4907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mingw builds set the alignment requirement for complex doubles types to 16 byte so the tests checking the alignment flag must be disabled.
|
this means stuff may be slower on win32 due to requiring using unaligned paths on a platform that does not need them. The simplest way to fix that would be to use an aligned allocator. |
charris
added a commit
that referenced
this pull request
Jul 27, 2014
TST: win32 also does not provide 16 byte alignment
|
An aligned allocator would be nice. We've been talking about one for nearly 6 years now ;) |
|
Sorry for opening a similar issue, I didn't see this one in advance. Anyway, regarding an aligned allocator: #5312 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mingw builds set the alignment requirement for complex doubles types to
16 byte so the tests checking the alignment flag must be disabled as win32 only provides 8 bytes.