Skip to content

disable ufunc override for 1.9 release #4920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 30, 2014

Conversation

juliantaylor
Copy link
Contributor

The ufunc override __numpy_ufunc__ still has a few unresolved issues
regarding its behavior towards Python operators see gh-4815.
To avoid releasing numpy with an interface that might change in the next
numpy version and to not further delay the 1.9 release it has been
decided to disable the feature in 1.9.0.

  • a bugfix that had to be cherry picked.

@juliantaylor
Copy link
Contributor Author

I think we should be ready then to prepare the 1.9 beta2, I really wanted to update our mingw toolchain for 1.9 too but I don't have the windows debugging experience to fix the issues in #4909, so that will be a task for 1.10.

@charris
Copy link
Member

charris commented Jul 29, 2014

LGTM pending Travis.

The ufunc override `__numpy_ufunc__` still has a few unresolved issues
regarding its behavior towards Python operators see numpygh-4815.
To avoid releasing numpy with an interface that might change in the next
numpy version and to not further delay the 1.9 release it has been
decided to disable the feature in 1.9.0.
charris added a commit that referenced this pull request Jul 30, 2014
disable ufunc override for 1.9 release
@charris charris merged commit 9cd9c6c into numpy:maintenance/1.9.x Jul 30, 2014
@charris
Copy link
Member

charris commented Jul 30, 2014

Thanks Julian.

@pv
Copy link
Member

pv commented Jul 30, 2014

Also the has_ufunc_override in number.c should probably be changed.

juliantaylor added a commit to juliantaylor/numpy that referenced this pull request Jul 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants