MAINT: Make numpy/lib/polynomial/polyval a bit faster. #5031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiplying a numpy_scalar times a numpy_array is much faster than the other way around. This PR switches the order of multiplication in the polyval function resulting in a speedup of about 5x for scalar values of x. Closes numpy#4610.
|
Umm, ok, why not :). |
seberg
added a commit
that referenced
this pull request
Sep 2, 2014
MAINT: Make numpy/lib/polynomial/polyval a bit faster.
|
so simple its almost tempting to put that into 1.9 :) |
|
Is there any documentation on how exactly Python resolves the multiplication? Calling |
|
I am sure there is some PEP somewhere. I believe it calls |
|
Oh, you mention it is even slower. There are C-level slots for these operators as well in the number slots. Those make it somewhat faster then what you would write in python. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiplying a numpy_scalar times a numpy_array is much faster than
the other way around. This PR switches the order of multiplication
in the polyval function resulting in a speedup of about 5x for scalar
values of x.
Closes #4610.