-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
Fix #5312: use an aligned allocator. #5457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Introduce two new functions, get_data_alignment() and set_data_alignment() which allow setting the guaranteed alignment at runtime.
an issue is that with this pointers can't be freed with free anymore, so technically an ABI break. |
I noticed that PyDataMem_RENEW() is obviously wrong the base pointer changes alignment. Fixing, but this adds some overhead in cases where the base offset changes. |
Conflicts: numpy/core/src/multiarray/multiarraymodule.c
There is a "ready for review" tag, not sure if it helps here... I guess the problem is getting someone to review who knows this better. Anyway, you are right, this is one that could be reactivate, but may need prodding reviewers a bit :). |
okay thanks for the summary @seberg. I guess I will tag this and the other pr Ready for Review and revisit this later. |
Thanks for this! I will close it, since it is now superseded by gh-17582 and NEP 49 — Data allocation strategies. |
Introduce two new functions, get_data_alignment() and set_data_alignment() which allow
setting the guaranteed alignment at runtime.