BUG: Fix astype for structured array fields of different byte order. #5480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The offending commit is c53b0e4, which introduced two regressions: - using astype to cast a structured array to one with a different byte order no longer works; - comparing structured-array dtypes can give incorrect results if the two dtypes have different byte orders. This pull request should fix both. One thing I wasn't sure about is reordering struct fields. In my implementation, the `equiv`, `same_kind`, and `safe` rules are now allowed to reorder fields. If that isn't desired, though, it's a pretty easy change.
|
Unfortunately, this does not rebase cleanly for backport, so will cherry-pick. |
|
Cleanup of #5279. |
charris
added a commit
that referenced
this pull request
Jan 22, 2015
BUG: Fix astype for structured array fields of different byte order.
charris
referenced
this pull request
Jan 22, 2015
BUG: Fix astype for structured array fields of different byte order.
This was referenced Jan 11, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The offending commit is c53b0e4, which introduced two regressions:
order no longer works;
two dtypes have different byte orders.
This pull request should fix both.
One thing I wasn't sure about is reordering struct fields. In my
implementation, the
equiv,same_kind, andsaferules are nowallowed to reorder fields. If that isn't desired, though, it's a pretty
easy change.