BUG: segfault in array_richcompare #5960
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1358,18 +1358,17 @@ array_richcompare(PyArrayObject *self, PyObject *other, int cmp_op) | |||
| _res = PyArray_CanCastTypeTo(PyArray_DESCR(self), | |||
| PyArray_DESCR(array_other), | |||
| NPY_EQUIV_CASTING); | |||
| Py_XDECREF(result); | |||
There was a problem hiding this comment.
I don't think this is quite right here (or below), as a NULL return indicates that PyArray_GenericBinaryFunction encountered an error. Probably something like
if (result == NULL) {
PyErr_Clear();
}
else {
Py_DECREF(result);
}
Somehow I think the logic in this function can be cleaned up, but that might be for another day.
a696688 to
bee7fe5
Compare
|
That makes a lot more sense, I had thought Updated + added a test. |
|
Oh, I just noticed that #5864 probably fixes this in a better way. Feel free to take the unit test for use there, if wanted. |
charris
added a commit
to charris/numpy
that referenced
this pull request
Jun 14, 2015
Fixed by numpy#5964, but might as well keep the test from numpy#5960.
charris
referenced
this pull request
Jun 14, 2015
TST: Add test for segfault in richcompare of void type ==, !=.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4855. Only real change was
Py_DECREF(result)becamePy_XDECREF(result).I assume the other logic there is fine, I don't know ufunc code very well.