MAINT: document change to bytestring index behavior #5977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bytestring indices now raise IndexError, not ValueError [ci skip]
|
Thanks. How did bytestring indexing used to work, was it for structured arrays? |
|
As far as I understand, bytestring indexing never worked for anything. Unit tests were added to make sure they didn't work, in case code involving unicode/strings accidentally accepted them. I can see that #3798 has already partially converted the ValueErrors to IndexErrors, so my changes can be seen as a continuation of that. |
charris
added a commit
that referenced
this pull request
Jun 17, 2015
MAINT: document change to bytestring index behavior
|
I was asking because I had never heard of bytestring indexing and had no idea what it was supposed to do. |
This was referenced Jun 17, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@charris I guess there was one change in #5636 which maybe needs documenting:
Indexing with a byte-string in python 3 now raises IndexError, not ValueError.
Indexing with a bytestring has never done anything useful so I can't imagine anyone caring, but here's a release note for it if desired.