Skip to content

PEP8 and pyflakes fixups for numpy/core/tests/*.py #6047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 25, 2015

Conversation

charris
Copy link
Member

@charris charris commented Jul 5, 2015

The fixes do not include the pretty formatting of array data. Long
lines are also left intact at this point.

This one is still a WIP, needs application of pyflakes.

EDIT: OK, this one should be done.

@charris charris added this to the 1.10.0 release milestone Jul 5, 2015
@charris charris changed the title STY: PEP8 fixes for numpy/core/tests/*.py PEP8 and pyflakes fixups for numpy/core/tests/*.py Jul 5, 2015
@charris charris force-pushed the pep8-pyflakes-numpy.core.tests branch from 8a3d5a3 to baa63b4 Compare July 23, 2015 18:48
@charris
Copy link
Member Author

charris commented Jul 24, 2015

This one is ready.

charris added 4 commits July 25, 2015 13:31
The fixes do not include the pretty formatting of array data. Lond
lines are also left intact at this point.
There were two classes named TestArrayPriority in test_multiarray.py,
both of which tested the use of the __array_priority__ attribute.
Because the later addition tests more functions than the earlier one and
for more dtypes, the earlier version is removed.
Many of these fixups are result from removing `from x import *`
imports. The rest are mostly unused variable fixes.
The dot tests in test_numeric have not done anything useful since the
_dotblas module was merged into multiarray. There used to be two
potentially different dot functions, one from _dotblas and the other
from multiarray, that the tests compared against each other. Because
both functions are now the same that no longer serves any purpose, so
those tests have been modified to check against known results and moved
into test_multiarray with the other dot tests.

The dot tests could use improvement. They don't check all the types,
exceptions, and such. But fixing them exceeds the scope of the present
work.
@charris charris force-pushed the pep8-pyflakes-numpy.core.tests branch from baa63b4 to 730adaa Compare July 25, 2015 19:32
charris added a commit that referenced this pull request Jul 25, 2015
PEP8 and pyflakes  fixups for numpy/core/tests/*.py
@charris charris merged commit 9918d35 into numpy:master Jul 25, 2015
@charris charris deleted the pep8-pyflakes-numpy.core.tests branch July 25, 2015 19:56
@charris
Copy link
Member Author

charris commented Jul 25, 2015

Merging this for the 1.10 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant