Handle empty inputs in cov and corrcoef. #63
Closed
+21
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See also http://projects.scipy.org/numpy/ticket/440, same issue for mean/median/average. Should be handled the same way probably, no matter what the final desired behavior is. |
|
And http://projects.scipy.org/numpy/ticket/1387, bincount gives a ValueError |
|
Shape is preserved now, see SHA:149e10f58209ce698bbbe1fdf820c55e943bb743 I can merge those to a single commit before pushing. |
|
Grr, that Markdown for commits is horrible. |
|
Looks OK to me. |
|
applied |
fangerer
added a commit
to hpyproject/numpy-hpy
that referenced
this pull request
Jul 7, 2022
…r API Merge in ~STEPAN.SINDELAR_ORACLE.COM/numpy-hpy from fa/cast_info_xfree to labs-hpy-port * commit '4222a3e193219deccdc5bc13c000b43d9387e577': Migrate function signature NpyIter_IterNextFunc to HPy Use HNpyIter_GetInnerFixedStrideArray in execute_ufunc_loop Completely remove npyiter_allocate_buffers Directly use HNPY_cast_info_xfree
luyahan
pushed a commit
to plctlab/numpy
that referenced
this pull request
Apr 25, 2024
feat: Add vraddhn_s16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty inputs to cov and corrcoef now result in warnings, and return 0 and 1 respectively. This is correct for scalar input but makes no sense for empty input. Raising an exception is also not appreciated usually, so just doing: empty in -> empty out, seems like the most straightforward thing.
Also fixes a minor doc bug and adds a few tests.
Closes #1773.