Skip to content

FutureWarning for np.full(..., non-float). #6382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2015

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Sep 28, 2015

cf. discussion in #6366.

@seberg @njsmith @charris
Please consider whether this can make it to 1.10.rc2 to get at least some testing before the actual release.

@njsmith
Copy link
Member

njsmith commented Sep 28, 2015

Lgtm. @charris, what do you think?

charris added a commit that referenced this pull request Sep 28, 2015
FutureWarning for np.full(..., non-float).
@charris charris merged commit 807e01c into numpy:master Sep 28, 2015
@charris
Copy link
Member

charris commented Sep 28, 2015

LGTM also. Thanks @anntzer .

@charris charris added this to the 1.10.0 release milestone Sep 28, 2015
@njsmith
Copy link
Member

njsmith commented Sep 28, 2015

Doh, only looking at the backport go by do I realize that this is missing a test. Don't really want to delay 1.10rc2 over it, but @anntzer if you have a few minutes it'd be good to have (in master if nothing else).

@anntzer
Copy link
Contributor Author

anntzer commented Sep 28, 2015

in test_numeric or in test_deprecations?

@njsmith
Copy link
Member

njsmith commented Sep 28, 2015

test_deprecations

Unless you'd rather do it the other way. It really doesn't matter much :-)
On Sep 28, 2015 12:49 PM, "Antony Lee" notifications@github.com wrote:

in test_numeric or in test_deprecations?


Reply to this email directly or view it on GitHub
#6382 (comment).

@anntzer anntzer mentioned this pull request Sep 28, 2015
charris added a commit that referenced this pull request Sep 28, 2015
@rkern
Copy link
Member

rkern commented Oct 11, 2015

This behavior is confusing. http://stackoverflow.com/questions/33070449/why-does-np-full-raise-a-futurewarning

In the case where the user explicitly specifies the dtype, the behavior will not be different in the future, so there should be no warning. It's only when the user does not explicitly specify the dtype as something other than None that the behavior will change in the future.

anntzer added a commit to anntzer/numpy that referenced this pull request Oct 11, 2015
@anntzer
Copy link
Contributor Author

anntzer commented Oct 11, 2015

Apologies, see #6449.

charris pushed a commit to charris/numpy that referenced this pull request Oct 11, 2015
jaimefrio pushed a commit to jaimefrio/numpy that referenced this pull request Mar 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants