Skip to content

Change the default error state to 'warn' #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Change the default error state to 'warn' #65

wants to merge 3 commits into from

Conversation

rkern
Copy link
Member

@rkern rkern commented Mar 30, 2011

ENH: Change the default error handling to warn instead of print, except for underflow, which remains ignored.

@charris
Copy link
Member

charris commented Mar 31, 2011

If this goes into 1.6 it should be mentioned in the release notes. Some tests might help avoid accidental changes in the future, although that might also depend on the order in which tests are executes.

@rgommers
Copy link
Member

rgommers commented Apr 1, 2011

Tests should also be careful to reset the state, so testing should be straightforward. Something like:

def test_default_fpe():
    err = np.geterr()
    assert_(err['over'] == 'warn')
    assert_(err['divide'] == 'warn')
    assert_(err['invalid'] == 'warn')
    assert_(err['under'] == 'ignore')

@rkern
Copy link
Member Author

rkern commented Apr 1, 2011

Added.

…seterr test case to take the new defaults into account.
@charris
Copy link
Member

charris commented Apr 2, 2011

Merged.

@charris charris closed this Apr 2, 2011
fangerer added a commit to hpyproject/numpy-hpy that referenced this pull request Jul 7, 2022
Merge in ~STEPAN.SINDELAR_ORACLE.COM/numpy-hpy from fa/fix_HPyIsAligned to labs-hpy-port

* commit '39f4cf6ae8027ad38cfa235003ddc6b3c27aebbc':
  Fix: missing return in HPyIsAligned
luyahan pushed a commit to plctlab/numpy that referenced this pull request Apr 25, 2024
feat: Add vmull_[s16|s32|u8|u16|u32]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants