BUG: Fix for #6719 #6721
Merged
BUG: Fix for #6719 #6721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -127,6 +127,7 @@ cdef extern from "initarray.h": | |||
| # Initialize numpy | |||
| import_array() | |||
|
|
|||
| import cython | |||
There was a problem hiding this comment.
Does cimport cython work? That is what the cython documentation uses for examples.
|
Should I squash the two commits into one? |
|
Yes, please do. |
numpy/random/mtrand/mtrand.pyx contains a line where cython fails to compile, complaining “Pythonic division not allowed without gil”. By running this code segment under cdivision(True), this problem is avoided.
9694ad5 to
4e276ac
Compare
|
@charris Done, I believe. |
|
OK, might as well put this in as it seems otherwise harmless. You might send an inquiry to the Cython folks. |
|
Thanks @gerritholl . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
numpy/random/mtrand/mtrand.pyx contains a line where cython fails to
compile, complaining “Pythonic division not allowed without gil”. By
running this code segment under cdivision(True), this problem is avoided.