BUG/TST: Fix #6760 by correctly describing mask on nested subdtypes #6761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8d82fe9 to
8c1e3e0
Compare
Fix numpy#6760. In ma.core._recursive_make_descr, consider the case where a subdtype does itself have named fields. This ensures the correct mask for an array like `ma.zeros(2, dtype([("A", "(2,2)i1,(2,2)i1", (2,2))]))`.
8c1e3e0 to
c8a0982
Compare
| @@ -1248,7 +1248,7 @@ def _recursive_make_descr(datatype, newtype=bool_): | |||
| # Is this some kind of composite a la (np.float,2) | |||
| elif datatype.subdtype: | |||
| mdescr = list(datatype.subdtype) | |||
| mdescr[0] = newtype | |||
| mdescr[0] = _recursive_make_descr(datatype.subdtype[0], newtype) | |||
There was a problem hiding this comment.
Out of curiosity, why always the 0 index?
charris
added a commit
that referenced
this pull request
Dec 3, 2015
…ay_maskfill BUG/TST: Fix #6760 by correctly describing mask on nested subdtypes
|
LGTM, thanks @gerritholl . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6760. In ma.core._recursive_make_descr, consider the case where a
subdtype does itself have named fields. This ensures the correct mask for
an array like
ma.zeros(2, dtype([("A", "(2,2)i1,(2,2)i1", (2,2))])).