REL: Reset strides for RELAXED_STRIDE_CHECKING for 1.13 releases. #7085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strides in some cases are set to NPY_MAX_INTP to smoke out illegal usage in packages that use Numpy. We don't want that for the releases, so fix it.
|
@charris did you intend to merge this now, or right before the next release? |
|
@rgommers This is for the next release. |
|
OK I'll keep my hands off the green button then. |
|
I've pushed this on to 1.13.0 after a backport to 1.12.x. I'm not sure we want to keep this around much longer. |
|
Close and reopen to restart tests. |
|
Closing in favor of #8999. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply for the 1.12 release, not before.
Strides in some cases are set to NPY_MAX_INTP to smoke out illegal usage
in packages that use Numpy. We don't want that for the releases, so fix
it.