Memory leaks #79
Closed
Memory leaks #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (Python 2.7, RHEL5), the call to func.__name__ returns a temporary Python string object with only a single reference. Dereferencing it before copying out its contents results in reading freed memory.
|
All of those are clearly bugs, the fixes look correct to me, and the tests succeed, so I've merged them. |
fangerer
pushed a commit
to hpyproject/numpy-hpy
that referenced
this pull request
Dec 12, 2022
Merge in ~STEPAN.SINDELAR_ORACLE.COM/numpy-hpy from mq/GR-40354 to labs-hpy-port * commit 'f4cf11d2341e1734b8da1035c63e876daaacb600': address comments implement more missing pieces Implement missing pieces
luyahan
pushed a commit
to plctlab/numpy
that referenced
this pull request
Apr 25, 2024
feat: Add vmovn_s16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few reference counting and memory management bugs found by running the nose tests under valgrind. Some of these only affect running the tests themselves and can be considered a low priority. However, the one in ufunc_frompyfunc actually caused a segfault for me -- it should probably be fixed in the release candidate before the official release.