-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
MAINT: Add Tempita to randint helpers #8071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adding
at line 56 of |
Fair enough, though I would prefer my fix in #8066 just because it is a more long-term patch. |
I think the root cause is that |
Not sure either, though not sticking to one Python version while installing seems buggy to me anyhow. |
So how about the easy fix for this PR, then the larger fix can go in afterward after consideration. |
Many systems run/build with multiple python versions. However, I don't think the python version used matters for processing the templates, so tempita could be run from the command line as |
@charris : Sure, but I still fail to see why we would want to use two different Python's in our testing environment. It would seem logical to just use one like we do with all the other tests. Not to mention, the virtual environment is being initialized incorrectly because |
I believe python3-dbg is used for the build.
Admittedly, the whole script is a bit obscure. That aside, I run with three python versions installed and like to build with any of them. Currently, I need to install cython for each to have tempita. It does work for python2 to use the command line The point is that this is not only a testing problem and the current universal solution is to simply install cython in the python used for the build. Whether or not to have a single python for each venv for testing is another question that I think comes down to whatever is simplest. Note that a simple fix here splits the problem into two disjoint subproblems, so this can go in without a dependency on a future change to the testing environment. |
Note that there used to be a copy of tempita included with numpy. We might want to revisit that idea, although it might take some work to unify the Python2 and Python3 versions. |
@charris : Sure, I don't have any issues making the patch that you proposed earlier. However, it would be worthwhile to work out this issue separately with this one build. And to reply to your point about that if-then statement. While it does set the |
@charris : Perhaps an email discussion might be useful for my other PR (regarding the Travis build configuration)? |
Refactors the randint helpers to use a Tempita template. This will reduce technical debt in the long run.
OK, let's get this in. Thanks @gfyoung . I think there is more cleanup work to do with cythonize, but we have something that works and folks who test master can start to offer feedback. The Travis test configuration is best done on the PR as that is what I monitor and what others can see, but perhaps a post to the list would be helpful in getting more people interested in taking a look. I think it mostly comes down to making a simple decision one way or the other. |
@charris : Yep, makes sense. Thanks! |
Refactors the
randint
helpers to use a Tempita template. This will reduce technical debt in the long run.In addition, this should help pave the way for the changes in #6938 to be smoothly integrated.
This PR depends on #8066, as that has the patch for the
DEBUG=1
machine.