Skip to content

ENH: decoupled the codes to use all cache buckets and optimized *zeros* for small chunks of memory. #8777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 11 commits into from
Closed

ENH: decoupled the codes to use all cache buckets and optimized *zeros* for small chunks of memory. #8777

wants to merge 11 commits into from

Conversation

blackball
Copy link

@blackball blackball commented Mar 13, 2017 •
edited by eric-wieser
Loading

I have changed the NCACHE_DIM from 15 to 7 in order to make the behavior consistent with the older version. This needs to be discussed, I will suggest to change NBUCKETS_DIM from 16 to 8 and NCACHE_DIM from 7 to 15.

Moved from #8755

@homu
Copy link
Contributor

homu commented Apr 7, 2017

☔ The latest upstream changes (presumably #8907) made this pull request unmergeable. Please resolve the merge conflicts.

@homu
Copy link
Contributor

homu commented Apr 30, 2017

☔ The latest upstream changes (presumably #8885) made this pull request unmergeable. Please resolve the merge conflicts.

@kurtqq
Copy link

kurtqq commented Feb 17, 2019

@blackball any update?

Base automatically changed from master to main March 4, 2021 02:03
@InessaPawson InessaPawson added 52 - Inactive Pending author response triage review Issue/PR to be discussed at the next triage meeting labels Jun 8, 2022
@InessaPawson InessaPawson added triaged Issue/PR that was discussed in a triage meeting and removed triage review Issue/PR to be discussed at the next triage meeting labels Jun 29, 2022
@seberg
Copy link
Member

seberg commented Jun 29, 2022

We discussed it briefly today, and didn't quite understand the full motivation behind the changes (I can see a cache bucket not being used, but not sure about the rest?).

Is this a compatibility issue (in which case its age probably defeats the purpose unfortunately) or a performance enhancement (in which case a benchmark or at least example would be good)?

The code also changed a bit so would require a rebase/updates. Please don't hesitate to open a new PR against the main branch though, and then we can discuss again, the main reason for closing at this point is simply age.

@seberg seberg closed this Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
01 - Enhancement 52 - Inactive Pending author response component: numpy._core triaged Issue/PR that was discussed in a triage meeting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@blackball @homu @kurtqq @seberg @charris @InessaPawson