MAINT: Include the function name in all argument error messages #8861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c85845b to
7fb7769
Compare
eric-wieser
commented
Mar 28, 2017
| @@ -3263,7 +3263,7 @@ array_can_cast_safely(PyObject *NPY_UNUSED(self), PyObject *args, | |||
| NPY_CASTING casting = NPY_SAFE_CASTING; | |||
| static char *kwlist[] = {"from", "to", "casting", NULL}; | |||
|
|
|||
| if(!PyArg_ParseTupleAndKeywords(args, kwds, "OO&|O&", kwlist, | |||
| if(!PyArg_ParseTupleAndKeywords(args, kwds, "OO&|O&:can_cast", kwlist, | |||
There was a problem hiding this comment.
It's a little annoying how sometimes the C and python function names are inconsistent, like here (can_cast vs can_cast_safely)
| @@ -2855,7 +2855,7 @@ array_fastCopyAndTranspose(PyObject *NPY_UNUSED(dummy), PyObject *args) | |||
| { | |||
| PyObject *a0; | |||
|
|
|||
| if (!PyArg_ParseTuple(args, "O", &a0)) { | |||
| if (!PyArg_ParseTuple(args, "O:fastCopyAndTranspose", &a0)) { | |||
There was a problem hiding this comment.
this is _fastCopyAndTranspose
|
looks good modulo one nitpick while greatly appreciated you should slow down a little with the changes to avoid a too fast burnout, also we don't have enough review time to keep up. |
Performed using the following regex, replacing with $0:$1. Some manual cleanup
was then required.
^[a-z]+_(\w+)(?:(?!\}).*\n)+.*PyArg_ParseTuple(AndKeywords)?\(args[^"]+"[^:"]+(?=")
7fb7769 to
dcafaf4
Compare
This was referenced Mar 28, 2017
My motto, "Gather ye rosebuds while ye may." Few last more than a few years in open source, the needs of life eventually take precedence... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performed using the following regex, replacing with
$0:$1. Some manual cleanupwas then required