BENCH: Masked array benchmarks #8929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
commented
Apr 11, 2017
| import numpy as np | ||
|
|
||
|
|
||
| class MA(Benchmark): |
There was a problem hiding this comment.
This was moved from bench_core. Is this a bad idea for asv?
There was a problem hiding this comment.
@pv Does this cause problems, or do cached results get recreated at some point.
f83c6ca to
78a1837
Compare
|
There's no cron job re-running for past commits.
But maybe there's nothing interesting in the history so you don't care.
|
|
Of course, anyone interested can always re-run the benchmarks on their
own machine(s).
|
|
Would doing "from bench_core import _MA as MA" solve this problem? |
|
Sorry, I mean the other way around - move the source as I've done here, but leave the test accessible under |
|
I suggest to not add any workarounds and just ignore the issue. Past
benchmark results can always be regenerated if there's some need for them.
|
Agree. The reorganization looks natural going forward. |
|
Thanks Eric. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some benchmarks that will hopefully detect the effects of #8910 and #8924.
Is this a reasonable set of things to benchmark, and is this the right way to structure them?