ENH: Print object arrays containing lists unambiguously #8989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 from me. Code LGTM. |
353d537 to
463a5a2
Compare
|
Updated with a release note, that also includes an entry about #8963, since they're related |
463a5a2 to
6f841d3
Compare
eric-wieser
commented
Apr 26, 2017
| @@ -256,6 +264,7 @@ def _get_formatdict(data, precision, suppress_small, formatter): | |||
| 'longcomplexfloat': lambda: LongComplexFormat(precision), | |||
| 'datetime': lambda: DatetimeFormat(data), | |||
| 'timedelta': lambda: TimedeltaFormat(data), | |||
| 'object': lambda: _object_format, | |||
| 'numpystr': lambda: repr_format, | |||
| 'str': lambda: str} | |||
There was a problem hiding this comment.
Interesting fact - this is never nor was ever used...
|
☔ The latest upstream changes (presumably #8967) made this pull request unmergeable. Please resolve the merge conflicts. |
Also adds a release note for numpygh-8963
|
Adding to the milestone since this contains a release note fix for an already-included feature |
|
Thanks Eric. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
Now