BUG: on Apple platforms changed long long format from "%Ld" to "%lld" #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /* #define LONGLONG_FMT "lld" Another possible variant | ||
| #define ULONGLONG_FMT "llu" | ||
|
|
||
| # elif defined __APPLE__ /* "%Ld" only parses 4 bytes on 32-bit MacOS X */ |
There was a problem hiding this comment.
Please don't use trailing comments, put it on the next line. Apropos trailing comments in general, I think they should be used sparingly, mostly for things like structure members, etc.
|
Actually on Linux "L" also is only documented as length modifier for floating point types - can anyone comment on what platforms would not support "%lld"? |
|
Apparently the "ll" formats were broken on FreeBSD at some point in the last millennium, thus the occasional use of the "q" alternatives. Both still work on OS X as well. |
|
From MSDN, it looks like Visual Studio introduced the 'll' format support in the 2005 version. |
|
I've merged the pull request. |
luyahan
pushed a commit
to plctlab/numpy
that referenced
this pull request
Apr 25, 2024
feat: Add vabal_s8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves a test failure on PPC with Mark's recent datetime updates, but should fix print formats on 32bit MacOS X in general, where "%Ld" would only use 4 bytes at a time. For an npy_int64 year=1970 this print
"%Ld - %Ld", year, year
produced "0 - 1970" on ppc and "1970 - 0" on i386, while "%lld - %lld" prints "1970 - 1970" on both archs.
"That proves that it's wrong on i386 as well, and it makes perfect sense for big endian and little endian architectures." (-Mark)