Skip to content

ENH: Use __array_ufunc__ = None in polynomial convenience classes. #9015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2017

Conversation

charris
Copy link
Member

@charris charris commented Apr 28, 2017

Add __array_ufunc__ = None to ABCPolyBase. This ensures that polynomial
convenience classes will not participate in ufuncs and will have priority
when combined with an ndarray in a Python binary operator.

__array_priority__ is removed, as it is no longer needed.

Add `__array_ufunc__ = None` to ABCPolyBase. This ensures that polynomial
convenience classes will not participate in ufuncs and will have priority
when combined with an ndarray in a Python binary operator.

`__array_priority__` is removed, as it is no longer needed.
@charris
Copy link
Member Author

charris commented Apr 28, 2017

There might be some question as to whether the old __array_priority__ should be kept around. I can't see a situation in which that would matter, pickled instances should naturally be reincarnated in the appropriate version when loaded.

@njsmith
Copy link
Member

njsmith commented Apr 29, 2017

I can't see a situation in which that would matter

Yeah, FWIW I can't either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants