allow specify dtype for fftfreq/rfftfreq #9126 #9150
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
requested changes
May 21, 2017
|
@eric-wieser I see, will fix that. Thanks for the review. |
|
No, because that if statement should not exist in the first place. I don't like this patch at all - right now its just a very convoluted way of spelling |
|
Oh, I didn't know the astype solution. |
|
Looking at the referenced issue, I think the actual request is that the output type match the type of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now able to specify a dtype for fftfreq/rfftfreq, mentioned in issue #9126