Structured dtype cleanup #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
June 21, 2011 13:07
This includes preserving the 'align=True' parameter through the new NPY_ALIGNED_STRUCT dtype flag. The code now detects whether the list version of structured dtype construction would match the data layout, to choose between list and struct based construction.
The 'struct'-based repr adds this parameter, as the general way to be able to reconstruct the dtype.
numpy#1790) In the case referenced in ticket numpy#1790, the itemsize was set before the padded size was calculated, so the intent was clearly that it should have been aligned.
This will require validation that object dtypes don't overlap with other fields in a follow-on commit.
| /* The alignment is always a power of 2, so this works */ | ||
| totalsize = (totalsize + maxalign - 1) & (-maxalign); | ||
| } | ||
|
|
||
| new = PyArray_DescrNewFromType(PyArray_VOID); |
There was a problem hiding this comment.
This is specifically the bugfix for #1790. That code (well, functionally equivalent code) was already there, just after assigning totalsize to new->elsize.
There was a problem hiding this comment.
So the filler is gone, you just provide enough aligned space for the item?
There was a problem hiding this comment.
I believe there never was any filler, just the illusion of filler created during the repr call.
|
Looks good as far as I am able to judge. |
added 5 commits
June 22, 2011 10:16
|
I've added some more commits:
|
luyahan
pushed a commit
to plctlab/numpy
that referenced
this pull request
Apr 25, 2024
feat: Add vshl_n_s8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of patches cleans up structured dtypes. In particular: