Tighten ufunc casting #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 22, 2011 09:09
This is an experimental change, to see what kind of ripple effects tightening up the semantics of NumPy just a little bit produce.
Since ones_like is a ufunc (unlike zeros_like and empty_like), it by default checks the casting rule. This disables that check completely.
|
Looks reasonable to me. |
luyahan
pushed a commit
to plctlab/numpy
that referenced
this pull request
Apr 25, 2024
chore: Fix saturate func warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tightens up the default casting rule used in ufuncs, from 'unsafe' to 'same_kind'.
http://mail.scipy.org/pipermail/numpy-discussion/2011-June/056605.html
The scipy fixes are awaiting review here:
scipy/scipy#38