Skip to content

MAINT: Move variables into deepest relevant scope, for clarity #9503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2017
Merged

MAINT: Move variables into deepest relevant scope, for clarity #9503

merged 1 commit into from
Jul 31, 2017

Conversation

eric-wieser
Copy link
Member

This missed #9499

@charris
Copy link
Member

charris commented Jul 31, 2017

LGTM, you can merge pending tests.

@charris
Copy link
Member

charris commented Jul 31, 2017

There is a lot of this sort of cleanup that can be done, it's good to get this slow improvement in the code, it makes it more readable. I suspect the compiler doesn't much care.

@eric-wieser eric-wieser merged commit 2bc9c0b into numpy:master Jul 31, 2017
@eric-wieser
Copy link
Member Author

Yep, I would hope this has no effect on compiled output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
03 - Maintenance component: numpy._core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eric-wieser @charris