ENH: Add broadcasting to randint #9576
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
969ac61 to
8b401b2
Compare
|
Note that #8717 allows zero size arrays. I haven't checked if this does that, but might be worth consiering. |
|
I saw that - it will be a small fix to this but wanted to make sure it was getting in before incorporating it. |
366ebc0 to
80b9a3f
Compare
|
I think this is finished, modulo reviews. It closes #8717 although I didn't put in the tests for empty choice. |
Refactor to allow consistent generation across multiple inputs for use in broadcasting
Add broadcasting for randint
Remove old rand int helpers Add tests for array versions Remove mask generator xref numpy#6938 xref numpy#6902 xref numpy#6745
Add fast path when size is not None and inputs are 1d or less since size will uniquely determine output
Refactor to avoid unnecessary repetition
Allow randint to handle zero size arrays to allow choice to function on empty inputs xref numpy#8717
Add tests that must take vector path to ensure it is tests
Add tests that must take vector path to ensure it is tests Replace np.bool_ with python bool
80b9a3f to
7c88a9c
Compare
|
This is currently in randomgen and may make it through there. Not essential here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of @gfyoung 's initial patch but using a different approach. This essentially produces a complete random integer generator including arg checks for each type. The int64/uint64 cases uses a separate path since special handling is required to ensure cast values are in bounds.
Related PR's and Issues: #6938 #6902 #6745