BUG: fix stray comma in _array2string #9815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6825c4d to
c4cb384
Compare
eric-wieser
reviewed
Oct 3, 2017
numpy/core/arrayprint.py
Outdated
| @@ -373,7 +373,7 @@ def wrapper(self, *args, **kwargs): | |||
| @_recursive_guard() | |||
| def _array2string(a, options, separator=' ', prefix=""): | |||
| if a.size > options['threshold']: | |||
| summary_insert = "..., " | |||
| summary_insert = "..." + separator | |||
There was a problem hiding this comment.
Can you push this inside _formatArray? It receives both arguments, so can concatenate them itself
|
Tests and fix looks good, just a minor refactor suggested |
_array2string unconditionally added a comma after the '...' that are inserted for arrays exceeding the size threshold. Instead, add the separator character in _formatArray. Fixes numpy#9777.
c4cb384 to
80c624e
Compare
|
@eric-wieser: moved the concatenation of summary_insert and the separator to _formatArray |
|
Thanks for your first contibution, @nafest. Adding a "needs release note" tag, in case we want to add a remark about this alongside all the other str/repr changes that are going into this release when we do a final pass over the release notes. |
This was referenced Nov 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_array2string unconditionally added a comma after the '...' that
are inserted for arrays exceeding the size threshold. Add the
separator character instead. Fixes #9777.