MAINT: Tidy up Maskedarray repr #9913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means we can implement `__unicode__` easily too, or perhaps `__format__` in future
2084109 to
6b41ba8
Compare
mhvk
approved these changes
Oct 24, 2017
numpy/ma/core.py
Outdated
| @@ -3829,10 +3833,10 @@ def compress(self, condition, axis=None, out=None): | |||
| _new._mask = _mask.compress(condition, axis=axis) | |||
| return _new | |||
|
|
|||
| def __str__(self): | |||
| def __insert_masked_print(self): | |||
There was a problem hiding this comment.
Only seeing this on this second reading, but I would make this "semi-private", i.e., a single underscore, partly just because it seems something people might want to call, but mostly since we don't use the class mangling much elsewhere in numpy
There was a problem hiding this comment.
we don't use the class mangling much elsewhere in numpy
We give the users great power, they have to provide the great responsibility :)
@eric-wieser I'll make the change and merge if that is OK with you.
|
Thanks Eric. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #9792, contains part of #9202 as well