MAINT: Rename formatters to match scalar type names #9962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
06638f4 to
a0ac2a6
Compare
a0ac2a6 to
f9368d8
Compare
|
Yeah I wasn't sure if it was better to go past 80 char lines, or move the strings to the left. LGTM. Ready to merge? |
|
Let's get this in. The classes need better docstrings, but that can go into another PR. Thanks Eric. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses some of my comments in #9941.
We've already broken compatibility by changing these names, so we might as well make them consistent with the scalar names.
Also, some PEP8 newlines added, and a fixup of some indentation problems.