Skip to content

Conversation

rossbar
Copy link
Collaborator

@rossbar rossbar commented Nov 10, 2020

Now that #36 is merged, update the remaining content to conform with the expected workflow. This PR

  • converts source files from .ipynb to .md
  • adds the tutorials to the main toctree on the sphinx site.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@rossbar
Copy link
Collaborator Author

rossbar commented Nov 10, 2020

Close/reopen

@rossbar rossbar closed this Nov 10, 2020
@rossbar rossbar reopened this Nov 10, 2020
@rossbar rossbar changed the title WIP: Update Moore's law tutorial with myst Update Moore's law and IO tutorial with myst Nov 10, 2020
@rossbar rossbar marked this pull request as ready for review November 10, 2020 23:06
Copy link
Member

@melissawm melissawm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @rossbar !

@melissawm
Copy link
Member

I have a couple of minor rendering issues (like text inside equations) that I can do before merging.

@rossbar do you think the solution above for the list numbering thing is reasonable? I can do that too.

@melissawm
Copy link
Member

In it goes 🎉 Good job, @cooperrc ! And thanks for the help, @rossbar !

@melissawm melissawm merged commit 3913646 into numpy:master Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants